-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #17 (for real this time) #19
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe recent changes involve a modification in the conditional statement related to the 'process ID' group within a shell script. This adjustment affects the execution of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
I haven't actually removed the check, more like a typo fix : P |
Tip For best results, initiate chat on the files or code changes. @Magniquick, thank you for clarifying the nature of the change in the New Learnings Added
|
zstyle ':completion:*:*:*:*:processes' command "ps -u $USER -o pid,user,comm -w -w" does fix all the processes not being completed, but AFAIK, fzf-tab-source only handles previews, right ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- sources/ps.zsh (1 hunks)
Files skipped from review due to trivial changes (1)
- sources/ps.zsh
Additional context used
Learnings (1)
Common learnings
User: Magniquick PR: Freed-Wu/fzf-tab-source#19 File: :0-0 Timestamp: 2024-04-21T10:12:00.892Z Learning: The change in the `sources/ps.zsh` file in PR #19 was a typo fix, not the removal of a conditional check involving the `$group` variable.
The fix is simple : P
note that even now not all the processes are shown.
Summary by CodeRabbit
ps
command by refining the conditional checks in the shell script.